Rcal 860 Allow roman datamodel as input to the exposure pipeline #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 79.39% 79.37% -0.03%
==========================================
Files 117 117
Lines 8076 8086 +10
==========================================
+ Hits 6412 6418 +6
- Misses 1664 1668 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
schlafly
approved these changes
Jul 8, 2024
zacharyburnett
pushed a commit
to zacharyburnett/romancal
that referenced
this pull request
Jul 22, 2024
…cetelescope#1296) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-860
Closes #1284
This PR allows the exposure pipeline to accept a roman datamodel as an input.
Checklist
CHANGES.rstunder the corresponding subsectionThe general regtests are failing at tweakreg (being worked on), https://github.com/spacetelescope/RegressionTests/actions/runs/9778658002/job/26996524484
But the test to see if the exposure pipeline accepts a roman data model is passing,
https://github.com/spacetelescope/RegressionTests/actions/runs/9778307535